Skip to content

feat: Add blacklisted commands feature #4140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

feat: Add blacklisted commands feature #4140

wants to merge 2 commits into from

Conversation

@SmartManoj
Copy link
Contributor

@SmartManoj SmartManoj commented May 30, 2025 •
edited by ellipsis-dev bot
Loading

Related GitHub Issue

#4138 (it has some other bugs?)

Description

Test Procedure

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Code Quality:
    • My code adheres to the project's style guidelines.
    • There are no new linting errors or warnings (npm run lint).
    • All debug code (e.g., console.log) has been removed.
  • Testing:
    • New and/or updated tests have been added to cover my changes.
    • All tests pass locally (npm test).
    • The application builds successfully with my changes.
  • Branch Hygiene: My branch is up-to-date (rebased) with the main branch.
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Changeset: A changeset has been created using npm run changeset if this PR includes user-facing changes or dependency updates.
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Documentation Updates

Additional Notes

Get in Touch

Important

Introduces a feature to manage blacklisted commands, preventing their execution even with auto-approval, with updates to settings, UI, and command validation logic.

  • Behavior:
    • Adds blacklistedCommands to globalSettingsSchema in global-settings.ts to block specific commands from execution.
    • Updates webviewMessageHandler to handle blacklistedCommands messages, updating global and workspace settings.
    • Modifies validateCommand() in command-validation.ts to check against blacklistedCommands.
  • UI:
    • Updates AutoApproveSettings.tsx to include UI for managing blacklistedCommands.
    • Updates SettingsView.tsx to handle blacklistedCommands state.
  • State Management:
    • Adds blacklistedCommands to ExtensionState in ExtensionStateContext.tsx.
    • Updates ExtensionMessage and WebviewMessage types to include blacklistedCommands.
  • Tests:
    • Adds tests for isBlacklistedSingleCommand() and updates validateCommand() tests in command-validation.test.ts.

This description was created by Ellipsis for ac4568c. You can customize this summary. It will automatically update as commits are pushed.

@SmartManoj SmartManoj requested review from cte and mrubens as code owners May 30, 2025 06:42
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 30, 2025
@vercel
Copy link

vercel bot commented May 30, 2025

@SmartManoj is attempting to deploy a commit to the Roo Code Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the enhancement New feature or request label May 30, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap May 30, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap May 30, 2025
@github-project-automation github-project-automation bot moved this from PR [Needs Prelim Review] to Done in Roo Code Roadmap May 30, 2025
@hannesrudolph hannesrudolph reopened this May 30, 2025
@github-project-automation github-project-automation bot moved this from Done to Triage in Roo Code Roadmap May 30, 2025
@github-project-automation github-project-automation bot moved this from Done to New in Roo Code Roadmap May 30, 2025
@hannesrudolph
Copy link
Collaborator

hannesrudolph commented May 30, 2025

Closing the PR. Not because the idea of blacklisting commands isn't useful (it actually might be), but because the current implementation isn't quite there. I'd prefer we discuss this approach more thoroughly before committing to it.

I'll move this over to discussion first. Let's nail down the specifics and see if we can find a cleaner way forward. The discussion will be on #4138 thread and should happen next week once we catchup on the backlog of issues.

@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap May 30, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap May 30, 2025
SmartManoj pushed a commit to SmartManoj/Raa-Code that referenced this pull request Jun 13, 2025
@0xToshii
replay evals (RooCodeInc#4140)
336eb46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrubens mrubens Awaiting requested review from mrubens mrubens is a code owner

@cte cte Awaiting requested review from cte cte is a code owner

Assignees

No one assigned

Labels

enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Roo Code Roadmap
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SmartManoj @hannesrudolph